Rancho-7 commented on code in PR #19347:
URL: https://github.com/apache/kafka/pull/19347#discussion_r2033222436
##########
tools/src/test/java/org/apache/kafka/tools/consumer/group/ConsumerGroupCommandTestUtils.java:
##########
@@ -38,58 +34,15 @@
import java.util.function.Consumer;
import java.util.function.Supplier;
-import static org.apache.kafka.common.test.api.Type.CO_KRAFT;
-import static
org.apache.kafka.coordinator.group.GroupCoordinatorConfig.CONSUMER_GROUP_HEARTBEAT_INTERVAL_MS_CONFIG;
-import static
org.apache.kafka.coordinator.group.GroupCoordinatorConfig.CONSUMER_GROUP_MIN_HEARTBEAT_INTERVAL_MS_CONFIG;
-import static
org.apache.kafka.coordinator.group.GroupCoordinatorConfig.GROUP_INITIAL_REBALANCE_DELAY_MS_CONFIG;
-import static
org.apache.kafka.coordinator.group.GroupCoordinatorConfig.OFFSETS_TOPIC_PARTITIONS_CONFIG;
-import static
org.apache.kafka.coordinator.group.GroupCoordinatorConfig.OFFSETS_TOPIC_REPLICATION_FACTOR_CONFIG;
/**
- * The old test framework {@link
kafka.api.BaseConsumerTest#getTestGroupProtocolParametersAll} test for the
following cases:
- * <ul>
- * <li>(KRAFT server) with (group.coordinator.new.enable=true) with
(classic group protocol) = 1 case</li>
- * <li>(KRAFT server) with (group.coordinator.new.enable=true) with
(consumer group protocol) = 1 case</li>
- * </ul>
- * <p>
- * The new test framework run seven cases for the following cases:
- * <ul>
- * <li>(KRAFT / CO_KRAFT servers) with
(group.coordinator.new.enable=false) with (classic group protocol) = 2
cases</li>
- * <li>(KRAFT / CO_KRAFT servers) with (group.coordinator.new.enable=true)
with (classic group protocol) = 2 cases</li>
- * <li>(KRAFT / CO_KRAFT servers) with (group.coordinator.new.enable=true)
with (consumer group protocol) = 2 cases</li>
- * </ul>
- * <p>
- * We can reduce the number of cases as same as the old test framework by
using the following methods:
- * <ul>
- * <li>(CO_KRAFT servers) with (group.coordinator.new.enable=true) with
(classic / consumer group protocols) = 2 cases</li>
- * </ul>
- * <ul>
- * <li>(KRAFT server) with (group.coordinator.new.enable=false) with
(classic group protocol) = 1 case</li>
- * </ul>
+ * This class provides methods to build and manage consumer instances, and
does not generate or manage Kafka clusters.
Review Comment:
Updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
