chia7712 commented on code in PR #19505:
URL: https://github.com/apache/kafka/pull/19505#discussion_r2049460553
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/share/ShareGroupConfigTest.java:
##########
@@ -89,24 +87,6 @@ public void testInvalidConfigs() {
assertEquals("Invalid value 11 for configuration
group.share.delivery.count.limit: Value must be no more than 10",
assertThrows(ConfigException.class, () ->
createConfig(configs)).getMessage());
- configs.clear();
- // test for when SHARE_GROUP_MAX_GROUPS_CONFIG is of incorrect data
type
- configs.put(ShareGroupConfig.SHARE_GROUP_MAX_GROUPS_CONFIG, 10);
Review Comment:
Should we add unit test for `SHARE_GROUP_MAX_SHARE_SESSIONS_CONFIG`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
