AndrewJSchofield commented on PR #19505: URL: https://github.com/apache/kafka/pull/19505#issuecomment-2823644245
> The changes LGTM. 1 doubt I have [here](https://github.com/apache/kafka/blob/b088ba799957081d9e549988b439bce405122900/group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupCoordinatorConfig.java#L318) we validate that group.share.max.size should be minimum 1 but KIP-932 says as minimum to be 10, do we know the reason? And if we want group.share.max.size to be minimum as 10 then should we increase the minimum for group.share.max.share.sessions to 10 as well? There's no right answer here for the minima. The defaults are more important, I think. The purpose of the `minimum(1)` is to prevent negative or zero values. If someone sets `group.share.max.share.sessions` to a value which is too low, consumption would be impacted, but setting the minimum value to 10 hardly makes any practical difference. So, I propose to leave the minimum values as they are. @apoorvmittal10 wdyt? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
