AndrewJSchofield commented on code in PR #19293: URL: https://github.com/apache/kafka/pull/19293#discussion_r2065960167
########## server-common/src/main/java/org/apache/kafka/server/common/MetadataVersion.java: ########## @@ -112,7 +112,22 @@ public enum MetadataVersion { // // Enables ELR by default for new clusters (KIP-966). - IBP_4_1_IV0(26, "4.1", "IV0", false); + IBP_4_1_IV0(26, "4.1", "IV0", false), + + // Enables share groups. Note, share groups are for preview only in 4.1. (KIP-932). + IBP_4_1_IV1(27, "4.1", "IV1", false), Review Comment: @junrao Let's call it ignorance. In principle, I think I could use `IBP_4_1_IV0`. I do note that there are several MV in the past which appear just to add a new RPC version such as `IBP_3_7_IV4`, which seems to fall into the same category. We have plenty of time to get this right before 4.1 chills. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org