jolshan commented on code in PR #19355:
URL: https://github.com/apache/kafka/pull/19355#discussion_r2068904148
##########
core/src/main/scala/kafka/server/KafkaApis.scala:
##########
@@ -2472,7 +2472,17 @@ class KafkaApis(val requestChannel: RequestChannel,
val filteredProducerIds =
listTransactionsRequest.data.producerIdFilters.asScala.map(Long.unbox).toSet
val filteredStates =
listTransactionsRequest.data.stateFilters.asScala.toSet
val durationFilter = listTransactionsRequest.data.durationFilter()
- val response = txnCoordinator.handleListTransactions(filteredProducerIds,
filteredStates, durationFilter)
+ val transactionalIdPatternFilter = if
(listTransactionsRequest.data.transactionalIdPattern == null) {
+ ""
Review Comment:
I see. I was looking at the lines directly above where we do check for null.
It's a bit confusing which things check for null vs empty 😓
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
