AndrewJSchofield commented on code in PR #19634:
URL: https://github.com/apache/kafka/pull/19634#discussion_r2072688367
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -1185,14 +1174,14 @@ public void testNoInterceptorCommitAsyncFailed() {
@Test
public void testRefreshCommittedOffsetsShouldNotResetIfFailedWithTimeout()
{
consumer = newConsumer();
- testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout(true);
+ testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout();
}
@Test
public void testRefreshCommittedOffsetsNotCalledIfNoGroupId() {
// Create consumer without group id so committed offsets are not used
for updating positions
consumer = newConsumerWithoutGroupId();
- testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout(false);
+ testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout();
Review Comment:
I'm not convinced by this test, or the previous one, at all. It looks like
they were trying to test something different, but actually do not. Please can
you dig into this a little deeper?
##########
clients/src/test/java/org/apache/kafka/clients/admin/MockAdminClient.java:
##########
@@ -507,7 +507,7 @@ private Map<String, KafkaFuture<TopicDescription>>
handleDescribeTopicsByNames(C
return topicDescriptions;
}
- public synchronized Map<Uuid, KafkaFuture<TopicDescription>>
handleDescribeTopicsUsingIds(Collection<Uuid> topicIds, DescribeTopicsOptions
options) {
+ public synchronized Map<Uuid, KafkaFuture<TopicDescription>>
handleDescribeTopicsUsingIds(Collection<Uuid> topicIds) {
Review Comment:
nit: Extra space
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
