wernerdv commented on code in PR #19634:
URL: https://github.com/apache/kafka/pull/19634#discussion_r2072915155
##########
clients/src/test/java/org/apache/kafka/clients/consumer/internals/AsyncKafkaConsumerTest.java:
##########
@@ -1185,14 +1174,14 @@ public void testNoInterceptorCommitAsyncFailed() {
@Test
public void testRefreshCommittedOffsetsShouldNotResetIfFailedWithTimeout()
{
consumer = newConsumer();
- testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout(true);
+ testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout();
}
@Test
public void testRefreshCommittedOffsetsNotCalledIfNoGroupId() {
// Create consumer without group id so committed offsets are not used
for updating positions
consumer = newConsumerWithoutGroupId();
- testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout(false);
+ testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout();
Review Comment:
The original logic that was associated with the method argument was removed
in
[commit](https://github.com/apache/kafka/commit/6744a718c2c177c7d462b231ea5e476d98f6eb38#diff-c588f5a3c612b1e655eccd370fd43085dd62c6886c1e7340c54123fa2fc55b47L1892)
.
It seems that after adding `CheckAndUpdatePositionsEvent` and refactoring
the `testUpdateFetchPositionsWithFetchCommittedOffsetsTimeout` method, the
`committedOffsetsEnabled` argument is no longer needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
