chia7712 commented on code in PR #19628:
URL: https://github.com/apache/kafka/pull/19628#discussion_r2072957378


##########
storage/src/test/java/org/apache/kafka/storage/internals/log/RemoteIndexCacheTest.java:
##########
@@ -376,6 +376,8 @@ public void testCleanerThreadShutdown() throws IOException, 
InterruptedException
         // close the cache properly
         cache.close();
         // verify that the thread is closed properly
+        TestUtils.waitForCondition(() -> getRunningCleanerThread().isEmpty(),

Review Comment:
   this new check is duplicate to existent check. Could you please remove old 
check?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to