kevin-wu24 commented on code in PR #19589:
URL: https://github.com/apache/kafka/pull/19589#discussion_r2077997793
##########
raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java:
##########
@@ -178,6 +182,7 @@ public void pollOnce() {
requestThread.doWork();
}
+ @SuppressWarnings("NPathComplexity")
Review Comment:
I think I did this, but I got a build error when running `./gradlew jar`.
It's pretty weird, because we're supposed to be on Java 17 according to gradle,
and my IDE said that this kind of `instanceof` `switch` matching is supported
in Java 17+. Let me try this and put the actual error message here.
##########
raft/src/main/java/org/apache/kafka/raft/KafkaNetworkChannel.java:
##########
@@ -178,6 +182,7 @@ public void pollOnce() {
requestThread.doWork();
}
+ @SuppressWarnings("NPathComplexity")
Review Comment:
I think I did this, but I got a build error when running `./gradlew jar`.
It's pretty weird, because we're supposed to be on Java 17 according to gradle,
and my IDE said that this kind of `instanceof` `switch` matching is supported
in Java 17+. Let me try this again and put the actual error message here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
