jsancio commented on code in PR #19589:
URL: https://github.com/apache/kafka/pull/19589#discussion_r2076114719
##########
raft/src/test/java/org/apache/kafka/raft/RaftClientTestContext.java:
##########
@@ -1261,6 +1288,23 @@ AddRaftVoterResponseData
assertSentAddVoterResponse(Errors error) {
return addVoterResponse;
}
+ RaftRequest.Outbound assertSentRemoveVoterRequest(
+ ReplicaKey replicaKey
+ ) {
+ List<RaftRequest.Outbound> sentRequests =
channel.drainSentRequests(Optional.of(ApiKeys.REMOVE_RAFT_VOTER));
+ assertEquals(1, sentRequests.size());
+
+ var request = sentRequests.get(0);
+ assertInstanceOf(RemoveRaftVoterRequestData.class, request.data());
+
+ var removeRaftVoterRequestData = (RemoveRaftVoterRequestData)
request.data();
+ assertEquals(clusterId, removeRaftVoterRequestData.clusterId());
+ assertEquals(replicaKey.id(), removeRaftVoterRequestData.voterId());
+
assertEquals(replicaKey.directoryId().orElse(ReplicaKey.NO_DIRECTORY_ID),
removeRaftVoterRequestData.voterDirectoryId());
Review Comment:
Same here. I think this is safer and more correct:
```java
assertEquals(replicaKey.directoryId().get(),
removeRaftVoterRequestData.voterDirectoryId());
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
