chia7712 commented on PR #19698:
URL: https://github.com/apache/kafka/pull/19698#issuecomment-2875248898
@xijiu thanks for this patch. Have you consider returning CompletableFuture
instead of throwing exception?
```java
if (!config.deleteTopicEnable) {
if (apiVersion < 3) {
return CompletableFuture.failedFuture(new
InvalidRequestException("Topic deletion is disabled."))
} else {
return CompletableFuture.failedFuture(new
TopicDeletionDisabledException())
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
