squah-confluent commented on code in PR #19677:
URL: https://github.com/apache/kafka/pull/19677#discussion_r2086378831
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java:
##########
@@ -218,6 +234,15 @@ private void maybeRevokePartitions() {
targetAssignment.put(memberId, new
MemberAssignmentImpl(newAssignment));
}
}
+
+ // Distribute the remaining extra partitions to the members that are
at or under the minimum
+ // quota. When there are remaining extra partitions, we can't run out
of unfilledMembers
+ // here because all members either subtracted from
remainingMembersToGetAnExtraPartition or
+ // went into the unfilledMembers list.
+ for (int i = 0; i < remainingMembersToGetAnExtraPartition; i++) {
+ unfilledMembers.get(i).remainingQuota++;
+ }
+ remainingMembersToGetAnExtraPartition = 0;
Review Comment:
Thanks for reviewing. I like this suggestion, I think it may be a bit
cleaner and we can make it work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
