dajac commented on code in PR #19677:
URL: https://github.com/apache/kafka/pull/19677#discussion_r2086647061
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/assignor/UniformHomogeneousAssignmentBuilder.java:
##########
@@ -218,6 +234,15 @@ private void maybeRevokePartitions() {
targetAssignment.put(memberId, new
MemberAssignmentImpl(newAssignment));
}
}
+
+ // Distribute the remaining extra partitions to the members that are
at or under the minimum
+ // quota. When there are remaining extra partitions, we can't run out
of unfilledMembers
+ // here because all members either subtracted from
remainingMembersToGetAnExtraPartition or
+ // went into the unfilledMembers list.
+ for (int i = 0; i < remainingMembersToGetAnExtraPartition; i++) {
+ unfilledMembers.get(i).remainingQuota++;
+ }
+ remainingMembersToGetAnExtraPartition = 0;
Review Comment:
Could you please put the results in the description too?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
