FrankYang0529 commented on PR #19611:
URL: https://github.com/apache/kafka/pull/19611#issuecomment-2876171380
> Out of curiosity, have you tried to run the benchmarks before and after
the change to see the impact?
Since previous `SubscribedTopicDescriberImpl` only supports
`numOfPartitions`, I only test this function. The result is 10^(-5) vs 10^(-6).
### This PR
```
Benchmark
(partitionsPerTopic) (topicCount) Mode Cnt Score Error Units
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 10 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 100 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 1000 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 10 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 100 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 1000 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 10 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 100 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 1000 avgt 5 ≈ 10⁻⁵ ms/op
JMH benchmarks done
```
<details>
<summary> SubscribedTopicDescriberImplBenchmark.java
</summary>
```java
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.jmh.assignor;
import org.apache.kafka.common.Uuid;
import
org.apache.kafka.coordinator.group.api.assignor.SubscribedTopicDescriber;
import
org.apache.kafka.coordinator.group.modern.SubscribedTopicDescriberImpl;
import org.apache.kafka.coordinator.group.modern.TopicIds;
import org.apache.kafka.image.MetadataImage;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Warmup;
import java.util.List;
import java.util.Set;
import java.util.concurrent.TimeUnit;
@State(Scope.Benchmark)
@Fork(value = 1)
@Warmup(iterations = 3)
@Measurement(iterations = 5)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public class SubscribedTopicDescriberImplBenchmark {
@Param({"5", "10", "50"})
private int partitionsPerTopic;
@Param({"10", "100", "1000"})
private int topicCount;
private List<String> allTopicNames = List.of();
private Set<Uuid> subscriptionTopicIdSet;
private MetadataImage metadataImage;
private TopicIds.TopicResolver topicResolver;
private SubscribedTopicDescriber subscribedTopicDescriber;
private String topicName;
private Uuid topicId;
private void setupTopics() {
allTopicNames = AssignorBenchmarkUtils.createTopicNames(topicCount);
topicName = allTopicNames.get(0);
metadataImage =
AssignorBenchmarkUtils.createMetadataImage(allTopicNames, partitionsPerTopic);
topicResolver = new
TopicIds.CachedTopicResolver(metadataImage.topics());
topicId = topicResolver.id(topicName);
subscriptionTopicIdSet =
AssignorBenchmarkUtils.subscriptionTopicIdSet(metadataImage);
subscribedTopicDescriber = new
SubscribedTopicDescriberImpl(subscriptionTopicIdSet, metadataImage);
}
@Setup(Level.Trial)
public void setup() {
setupTopics();
}
@Benchmark
public void testNumOfPartitions() {
subscribedTopicDescriber.numPartitions(topicId);
}
}
```
</details>
### trunk
```
Benchmark
(partitionsPerTopic) (topicCount) Mode Cnt Score Error Units
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 10 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 100 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
5 1000 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 10 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 100 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
10 1000 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 10 avgt 5 ≈ 10⁻⁵ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 100 avgt 5 ≈ 10⁻⁶ ms/op
SubscribedTopicDescriberImplBenchmark.testNumOfPartitions
50 1000 avgt 5 ≈ 10⁻⁶ ms/op
JMH benchmarks done
```
<details>
<summary> SubscribedTopicDescriberImplBenchmark.java
</summary>
```java
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
package org.apache.kafka.jmh.assignor;
import org.apache.kafka.common.Uuid;
import
org.apache.kafka.coordinator.group.api.assignor.SubscribedTopicDescriber;
import
org.apache.kafka.coordinator.group.modern.SubscribedTopicDescriberImpl;
import org.apache.kafka.coordinator.group.modern.TopicIds;
import org.apache.kafka.coordinator.group.modern.TopicMetadata;
import org.apache.kafka.image.MetadataImage;
import org.apache.kafka.image.TopicsImage;
import org.openjdk.jmh.annotations.Benchmark;
import org.openjdk.jmh.annotations.BenchmarkMode;
import org.openjdk.jmh.annotations.Fork;
import org.openjdk.jmh.annotations.Level;
import org.openjdk.jmh.annotations.Measurement;
import org.openjdk.jmh.annotations.Mode;
import org.openjdk.jmh.annotations.OutputTimeUnit;
import org.openjdk.jmh.annotations.Param;
import org.openjdk.jmh.annotations.Scope;
import org.openjdk.jmh.annotations.Setup;
import org.openjdk.jmh.annotations.State;
import org.openjdk.jmh.annotations.Warmup;
import java.util.List;
import java.util.Map;
import java.util.concurrent.TimeUnit;
@State(Scope.Benchmark)
@Fork(value = 1)
@Warmup(iterations = 3)
@Measurement(iterations = 5)
@BenchmarkMode(Mode.AverageTime)
@OutputTimeUnit(TimeUnit.MILLISECONDS)
public class SubscribedTopicDescriberImplBenchmark {
@Param({"5", "10", "50"})
private int partitionsPerTopic;
@Param({"10", "100", "1000"})
private int topicCount;
private List<String> allTopicNames = List.of();
private Map<String, TopicMetadata> subscriptionMetadata;
private TopicsImage topicsImage;
private TopicIds.TopicResolver topicResolver;
private SubscribedTopicDescriber subscribedTopicDescriber;
private String topicName;
private Uuid topicId;
private void setupTopics() {
allTopicNames = AssignorBenchmarkUtils.createTopicNames(topicCount);
topicName = allTopicNames.get(0);
subscriptionMetadata =
AssignorBenchmarkUtils.createSubscriptionMetadata(allTopicNames,
partitionsPerTopic);
topicsImage =
AssignorBenchmarkUtils.createTopicsImage(subscriptionMetadata);
topicResolver = new TopicIds.CachedTopicResolver(topicsImage);
topicId = topicResolver.id(topicName);
Map<Uuid, TopicMetadata> topicMetadata =
AssignorBenchmarkUtils.createTopicMetadata(subscriptionMetadata);
subscribedTopicDescriber = new
SubscribedTopicDescriberImpl(topicMetadata);
}
@Setup(Level.Trial)
public void setup() {
setupTopics();
}
@Benchmark
public void testNumOfPartitions() {
subscribedTopicDescriber.numPartitions(topicId);
}
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
