FrankYang0529 commented on code in PR #19611:
URL: https://github.com/apache/kafka/pull/19611#discussion_r2094374099
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/assignor/OptimizedUniformAssignmentBuilderTest.java:
##########
@@ -245,22 +237,21 @@ public void
testFirstAssignmentNumMembersGreaterThanTotalNumPartitions() {
@Test
public void testValidityAndBalanceForLargeSampleSet() {
- Map<Uuid, TopicMetadata> topicMetadata = new HashMap<>();
- for (int i = 1; i < 100; i++) {
+ MetadataImageBuilder metadataImageBuilder = new MetadataImageBuilder();
+ Set<Uuid> topicIds = new HashSet<>();
+ IntStream.range(1, 101).forEach(i -> {
Review Comment:
Updated it.
##########
group-coordinator/src/test/java/org/apache/kafka/coordinator/group/modern/SubscribedTopicMetadataTest.java:
##########
@@ -17,94 +17,111 @@
package org.apache.kafka.coordinator.group.modern;
import org.apache.kafka.common.Uuid;
+import org.apache.kafka.coordinator.group.MetadataImageBuilder;
+import org.apache.kafka.image.MetadataImage;
import org.junit.jupiter.api.BeforeEach;
import org.junit.jupiter.api.Test;
-import java.util.HashMap;
import java.util.Map;
+import java.util.Optional;
import java.util.Set;
+import java.util.stream.IntStream;
import static org.junit.jupiter.api.Assertions.assertEquals;
import static org.junit.jupiter.api.Assertions.assertNotEquals;
import static org.junit.jupiter.api.Assertions.assertThrows;
public class SubscribedTopicMetadataTest {
- private Map<Uuid, TopicMetadata> topicMetadataMap;
private SubscribedTopicDescriberImpl subscribedTopicMetadata;
+ private MetadataImage metadataImage;
+ private final int numPartitions = 5;
@BeforeEach
public void setUp() {
- topicMetadataMap = new HashMap<>();
- for (int i = 0; i < 5; i++) {
+ MetadataImageBuilder metadataImageBuilder = new MetadataImageBuilder();
+ IntStream.range(0, 5).forEach(i -> {
Review Comment:
Updated it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
