adixitconfluent commented on code in PR #19786:
URL: https://github.com/apache/kafka/pull/19786#discussion_r2105902573
##########
core/src/test/java/kafka/server/share/SharePartitionManagerTest.java:
##########
@@ -3167,7 +3162,7 @@ private void validateBrokerTopicStatsMetrics(
static Seq<Tuple2<TopicIdPartition, LogReadResult>>
buildLogReadResult(List<TopicIdPartition> topicIdPartitions) {
List<Tuple2<TopicIdPartition, LogReadResult>> logReadResults = new
ArrayList<>();
topicIdPartitions.forEach(topicIdPartition -> logReadResults.add(new
Tuple2<>(topicIdPartition, new LogReadResult(
- new FetchDataInfo(new LogOffsetMetadata(0, 0, 0),
MemoryRecords.EMPTY),
+ new FetchDataInfo(new LogOffsetMetadata(0, 0, 0),
MemoryRecords.withRecords(Compression.NONE, new
SimpleRecord("test-key".getBytes(), "test-value".getBytes()))),
Review Comment:
nit: For better readability, can we change the line to
```
new FetchDataInfo(new LogOffsetMetadata(0, 0, 0), MemoryRecords.withRecords(
Compression.NONE, new SimpleRecord("test-key".getBytes(),
"test-value".getBytes()))),
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
