adixitconfluent commented on PR #19786: URL: https://github.com/apache/kafka/pull/19786#issuecomment-2906974603
> Thank you for kind code review. I resolved all you mentioned. Also, I want you to see if testMultipleConcurrentShareFetches works as it is intended. I don't think doAnswer chaning (line 1072 ~ 1101 in sharePartitionManagerTest.java) works well in multi threading test. Even though I changed values of assertEquals in doAnswer chaining to random value, test passed as well. It needs to be checked that chaining works well even in multi thread test. @ji-seung-ryu , hmm, I think you're right. I have created a ticket https://issues.apache.org/jira/browse/KAFKA-19328 for tracking the same. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
