kevin-wu24 commented on PR #19668: URL: https://github.com/apache/kafka/pull/19668#issuecomment-2913325616
A note about `KafkaRaftClient#maybeSendRequest` and the `RequestManager`, stemming sort of off of the redundancy mentioned for FETCH [here](https://github.com/apache/kafka/pull/19668#discussion_r2098713276): I think that presently, the RequestManager public api has a lot of methods because the object doesn't send the requests itself, but rather KafkaRaftClient does. The client contains the actual `MessageQueue` and `NetworkChannel` used to send requests and receive responses, but the `RequestManager` is the object managing the state around requests (enforcing the at most one request per node + at most one FETCH/FETCH_SNAPSHOT across all nodes invariants). This is out of scope for this PR, but I think we should refactor this so that the public `RequestManager` API should be only like two methods: 1. `maybeSendFetch` (for FETCH and FETCH_SNAPSHOT) 2. `maybeSend` (for all requests besides fetch) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
