AndrewJSchofield commented on code in PR #19818:
URL: https://github.com/apache/kafka/pull/19818#discussion_r2108744389
##########
clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareMembershipManager.java:
##########
@@ -137,16 +137,23 @@ public void
onHeartbeatSuccess(ShareGroupHeartbeatResponse response) {
"already leaving the group.", memberId, memberEpoch);
return;
}
- if (state == MemberState.UNSUBSCRIBED &&
maybeCompleteLeaveInProgress()) {
+ if (state == MemberState.UNSUBSCRIBED && responseData.memberEpoch() <
0 && maybeCompleteLeaveInProgress()) {
log.debug("Member {} with epoch {} received a successful response
to the heartbeat " +
- "to leave the group and completed the leave operation. ",
memberId, memberEpoch);
+ "to leave the group and completed the leave operation. ",
memberId, memberEpoch);
Review Comment:
nit: The indentation of this line is now inconsistent with the rest of the
method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
