brandboat commented on code in PR #19853:
URL: https://github.com/apache/kafka/pull/19853#discussion_r2122896658
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -435,14 +423,6 @@ public int remoteLogMetadataCustomMetadataMaxBytes() {
return
config.getInt(REMOTE_LOG_METADATA_CUSTOM_METADATA_MAX_BYTES_PROP);
}
- public String remoteStorageManagerPrefix() {
- return config.getString(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP);
- }
-
- public String remoteLogMetadataManagerPrefix() {
Review Comment:
How about adding @SuppressWarnings("unused") to those unused methods or
variables if we know they’re meant to be used elsewhere (or in the future)?
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManagerConfig.java:
##########
@@ -435,14 +423,6 @@ public int remoteLogMetadataCustomMetadataMaxBytes() {
return
config.getInt(REMOTE_LOG_METADATA_CUSTOM_METADATA_MAX_BYTES_PROP);
}
- public String remoteStorageManagerPrefix() {
- return config.getString(REMOTE_STORAGE_MANAGER_CONFIG_PREFIX_PROP);
- }
-
- public String remoteLogMetadataManagerPrefix() {
Review Comment:
How about adding `@SuppressWarnings("unused")` to those unused methods or
variables if we know they’re meant to be used elsewhere (or in the future)?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
