cadonna commented on code in PR #19889:
URL: https://github.com/apache/kafka/pull/19889#discussion_r2126093300


##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -4117,6 +4149,12 @@ private StreamThread buildStreamThread(final 
Consumer<byte[], byte[]> consumer,
             null
         );
     }
+
+    private void maybeRunStateUpdater(final boolean stateUpdaterEnabled) {
+        if (stateUpdaterEnabled) {
+            thread.taskManager().init();
+        }
+    }

Review Comment:
   Fair enough!
   I checked a couple of test methods and found that in at least two cases 
`maybeRunStateUpdater()` was not needed. The two cases are: 
`shouldRecordCommitLatency()` and `shouldChangeStateInRebalanceListener()`. 
There might still be others.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to