janchilling commented on code in PR #19889:
URL: https://github.com/apache/kafka/pull/19889#discussion_r2126080552
##########
streams/src/test/java/org/apache/kafka/streams/processor/internals/StreamThreadTest.java:
##########
@@ -4117,6 +4149,12 @@ private StreamThread buildStreamThread(final
Consumer<byte[], byte[]> consumer,
null
);
}
+
+ private void maybeRunStateUpdater(final boolean stateUpdaterEnabled) {
+ if (stateUpdaterEnabled) {
+ thread.taskManager().init();
+ }
+ }
Review Comment:
Hi @cadonna ,
I actually didn't call it in every test method, only in the ones where the
StreamThread is created by using the `StreamThreadTest#createStreamThread`.
Therefore, to keep the behavior uniform with the code, I included it in those
test cases.
That said, if the above approach isn’t ideal, another option could be to
include the call in the tests where tasks are not Restoring properly. I tried
this alternative as well, and all test cases passed with this approach as well.
Happy to adjust it either way, depending on what you think would be best.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
