m1a2st commented on code in PR #19883:
URL: https://github.com/apache/kafka/pull/19883#discussion_r2126864806
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5666,22 +5663,30 @@ class ReplicaManagerTest {
}
private def topicsCreateDelta(startId: Int, isStartIdLeader: Boolean,
partition:Int = 0, directoryIds: List[Uuid] = List.empty): TopicsDelta = {
+ topicsCreateDelta(startId, isStartIdLeader, List(partition), directoryIds,
"foo", FOO_UUID)
+ }
+
+ private def topicsCreateDelta(startId: Int, isStartIdLeader: Boolean,
partitions: List[Int],
+ directoryIds: List[Uuid], topicName: String,
topicId: Uuid): TopicsDelta = {
Review Comment:
What do you think about this adjustment
```suggestion
private def topicsCreateDelta(startId: Int, isStartIdLeader: Boolean,
partitions: List[Int] = List(0),
directoryIds: List[Uuid] = List.empty,
topicName: String = "foo", topicId: Uuid = FOO_UUID): TopicsDelta = {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
