jingjia88 commented on code in PR #19883:
URL: https://github.com/apache/kafka/pull/19883#discussion_r2126985653
##########
core/src/test/scala/unit/kafka/server/ReplicaManagerTest.scala:
##########
@@ -5666,22 +5663,30 @@ class ReplicaManagerTest {
}
private def topicsCreateDelta(startId: Int, isStartIdLeader: Boolean,
partition:Int = 0, directoryIds: List[Uuid] = List.empty): TopicsDelta = {
+ topicsCreateDelta(startId, isStartIdLeader, List(partition), directoryIds,
"foo", FOO_UUID)
+ }
+
+ private def topicsCreateDelta(startId: Int, isStartIdLeader: Boolean,
partitions: List[Int],
+ directoryIds: List[Uuid], topicName: String,
topicId: Uuid): TopicsDelta = {
Review Comment:
I used overloading here since a few existing calls would break due to
mismatched params if we used default args. But if you think default params make
it cleaner overall, happy to switch—what do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
