lucasbru commented on code in PR #19646:
URL: https://github.com/apache/kafka/pull/19646#discussion_r2132094755
##########
tools/src/test/java/org/apache/kafka/tools/streams/StreamsGroupCommandTest.java:
##########
@@ -335,43 +422,16 @@ public void testDeleteNonStreamsGroup() {
service.close();
}
- @Test
- public void testGroupStatesFromString() {
- Set<GroupState> result =
StreamsGroupCommand.groupStatesFromString("empty");
- assertEquals(new HashSet<>(List.of(GroupState.EMPTY)), result);
- result = StreamsGroupCommand.groupStatesFromString("EMPTY");
- assertEquals(new HashSet<>(List.of(GroupState.EMPTY)), result);
-
- result = StreamsGroupCommand.groupStatesFromString("notready");
- assertEquals(new HashSet<>(List.of(GroupState.NOT_READY)), result);
- result = StreamsGroupCommand.groupStatesFromString("notReady");
- assertEquals(new HashSet<>(List.of(GroupState.NOT_READY)), result);
-
- result = StreamsGroupCommand.groupStatesFromString("assigning");
- assertEquals(new HashSet<>(List.of(GroupState.ASSIGNING)), result);
- result = StreamsGroupCommand.groupStatesFromString("ASSIGNING");
- assertEquals(new HashSet<>(List.of(GroupState.ASSIGNING)), result);
-
- result = StreamsGroupCommand.groupStatesFromString("RECONCILING");
- assertEquals(new HashSet<>(List.of(GroupState.RECONCILING)), result);
- result = StreamsGroupCommand.groupStatesFromString("reconCILING");
- assertEquals(new HashSet<>(List.of(GroupState.RECONCILING)), result);
-
- result = StreamsGroupCommand.groupStatesFromString("STABLE");
- assertEquals(new HashSet<>(List.of(GroupState.STABLE)), result);
- result = StreamsGroupCommand.groupStatesFromString("stable");
- assertEquals(new HashSet<>(List.of(GroupState.STABLE)), result);
-
- result = StreamsGroupCommand.groupStatesFromString("DEAD");
- assertEquals(new HashSet<>(List.of(GroupState.DEAD)), result);
- result = StreamsGroupCommand.groupStatesFromString("dead");
- assertEquals(new HashSet<>(List.of(GroupState.DEAD)), result);
+ private ListGroupsResult listGroupResult(String groupId) {
+ KafkaFutureImpl<Collection<Object>> future = new KafkaFutureImpl<>();
+ GroupListing groupListing = new GroupListing(groupId,
Optional.of(GroupType.STREAMS), "streams", Optional.of(GroupState.DEAD));
+ future.complete(List.of(groupListing));
+ return new ListGroupsResult(future);
Review Comment:
Can you use mockito instead of this method, so that we do not have to make
the constructor public?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
