lianetm commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2962993263
Hey, thanks for looking into this! Sorry I haven't had the time to look in detail, but just couple of high level comments: - we need to be careful with aborting the find coord on close (ex. we do need to do it, if we have time, to send the pending async commits). - the console consumer behaviour is aligned really with the way it's calling `consumer.close()` here https://github.com/apache/kafka/blob/7c715c02c06f16475faff8aa72048cddb7382c8a/tools/src/main/java/org/apache/kafka/tools/consumer/ConsoleConsumer.java#L210 This means "close with default close timeout of 30s". So in a way, it's not unexpected that it waits right?. We should ensure that's what we want from the console consumers. Ex. calling `close(ZERO)` would be the way if we want to "close and attempt sending all requests once without retrying/waiting" -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
