ShivsundarR commented on PR #19886: URL: https://github.com/apache/kafka/pull/19886#issuecomment-2963857193
Hi @lianetm, thanks for the review. 1. So here the abort of the `FindCoordinator` will only happen when the network thread closes, i.e after all the pending async commits/acknowledgements have completed. So this should not affect the `findCoordinator` request issued for an async commit right? https://github.com/apache/kafka/blob/7c715c02c06f16475faff8aa72048cddb7382c8a/clients/src/main/java/org/apache/kafka/clients/consumer/internals/ShareConsumerImpl.java#L887C9-L888C163 2. I agree, we could go with `close(Duration.ZERO)` too to achieve immediate close on ctrl-c. We just need to decide if we want this functionality or not, seems like an immediate close on ctrl-C would be nice from a user experience perspective. I am just wondering if we make the `ConsoleConsumer`/`ConsoleShareConsumer` do a `close(Duration.ZERO)`, then on certain cases where we actually need some time to send async commits/acknowledgements, we might force close the consumer sooner. This could be an issue right? The PR currently only modifies the code when the network thread is closed(i.e after all the commits/acks have been sent/handled), so this ideally should not affect the prior steps in closing. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
