k-apol commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2146341727
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -555,21 +560,12 @@ public Set<String> makeReady(final Map<String,
InternalTopicConfig> topics) {
}
if (!topicsNotReady.isEmpty()) {
Review Comment:
I see what you're saying - some of this code is mostly harmless if it's half
baked (configs, maybe the new errors), but the init method could be fairly
destructive if it's not functionally complete.
I will keep that in mind as we move forward and for next time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
