k-apol commented on code in PR #19913:
URL: https://github.com/apache/kafka/pull/19913#discussion_r2146941932
##########
streams/src/main/java/org/apache/kafka/streams/processor/internals/InternalTopicManager.java:
##########
@@ -74,11 +76,14 @@ public class InternalTopicManager {
private final Time time;
private final Admin adminClient;
+ private final boolean isManualInternalTopicConfig;
private final short replicationFactor;
private final long windowChangeLogAdditionalRetention;
private final long retryBackOffMs;
private final long retryTimeoutMs;
+ private Duration initTimeout;
+ private boolean isInitializing = false;
Review Comment:
The problem I am trying to solve with the **isInitializing** flag is that,
as I understand from the KIP, we want to prevent makeReady from being invoked
by anything besides init when configured to do so. My idea was to set this flag
is set to true when the init method is used to invoke `makeReady`, and
`makeReady` turns it off at the end of it's work. This way, we can stop topics
from being created if `makeReady` is called explicitly, instead of via `init`
when applicable. Currently, it's tied to the timeout setting that also looks
like it's going to be refactored somehow. There are other ways to stop topics
from being created conditionally, and this was the simplest approach I could
think of.
This is where I currently try to decide whether or not topic creation is
valid, just before we actually start creating them on line 488
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
