jsancio commented on code in PR #19800:
URL: https://github.com/apache/kafka/pull/19800#discussion_r2150840804
##########
raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java:
##########
@@ -1514,19 +1527,22 @@ private CompletableFuture<FetchResponseData>
handleFetchRequest(
|| FetchResponse.recordsSize(partitionResponse) > 0
|| request.maxWaitMs() == 0
|| isPartitionDiverged(partitionResponse)
- || isPartitionSnapshotted(partitionResponse)) {
+ || isPartitionSnapshotted(partitionResponse)
+ || isHighWatermarkUpdated(partitionResponse, fetchPartition)) {
// Reply immediately if any of the following is true
// 1. The response contains an error
// 2. There are records in the response
// 3. The fetching replica doesn't want to wait for the partition
to contain new data
// 4. The fetching replica needs to truncate because the log
diverged
// 5. The fetching replica needs to fetch a snapshot
+ // 6. The fetching replica should update its high-watermark
Review Comment:
Yeah. That's fair. We should have a debug/trace message that indicates why
the RPC is getting completed or deferred.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
