jsancio commented on code in PR #19800: URL: https://github.com/apache/kafka/pull/19800#discussion_r2150825590
########## raft/src/main/java/org/apache/kafka/raft/KafkaRaftClient.java: ########## @@ -2882,6 +2908,7 @@ private FetchRequestData buildFetchRequest() { .setLastFetchedEpoch(log.lastFetchedEpoch()) .setFetchOffset(log.endOffset().offset()) .setReplicaDirectoryId(quorum.localDirectoryId()) + .setHighWatermark(quorum.highWatermark().map(LogOffsetMetadata::offset).orElse(-1L)) Review Comment: Correct. The version is negotiated using ApiVersions response and the field is ignorable. Since the field is ignorable, this fetch partition object can be serialized to version 18 and version 17. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org