chia7712 commented on code in PR #20002:
URL: https://github.com/apache/kafka/pull/20002#discussion_r2164544423
##########
core/src/test/scala/unit/kafka/server/AbstractApiVersionsRequestTest.scala:
##########
@@ -38,9 +38,9 @@ abstract class AbstractApiVersionsRequestTest(cluster:
ClusterInstance) {
def sendApiVersionsRequest(request: ApiVersionsRequest, listenerName:
ListenerName): ApiVersionsResponse = {
Review Comment:
this method is useless. please remove it
##########
test-common/test-common-runtime/src/test/java/org/apache/kafka/common/test/junit/ClusterTestExtensionsTest.java:
##########
@@ -189,9 +191,9 @@ public void testClusterTestWithDisksPerBroker() throws
ExecutionException, Inter
@ClusterTest(autoStart = AutoStart.NO)
public void testNoAutoStart() {
- Assertions.assertThrows(RuntimeException.class,
clusterInstance::anyBrokerSocketServer);
+ Assertions.assertThrows(RuntimeException.class, () ->
clusterInstance.brokers().values().stream().map(KafkaBroker::socketServer).findFirst());
clusterInstance.start();
- assertNotNull(clusterInstance.anyBrokerSocketServer());
+
assertTrue(clusterInstance.brokers().values().stream().map(KafkaBroker::socketServer).findFirst().isPresent());
Review Comment:
any updates?
##########
core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala:
##########
@@ -217,7 +217,7 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) {
else
InetAddress.getByName(entityName)
var currentServerQuota = 0
- currentServerQuota =
cluster.brokerSocketServers().asScala.head.connectionQuotas.connectionRateForIp(entityIp)
+ currentServerQuota =
cluster.brokers().values().asScala.head.socketServer.connectionQuotas.connectionRateForIp(entityIp)
Review Comment:
@gongxuanzhang any updates?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
