chia7712 commented on code in PR #20002:
URL: https://github.com/apache/kafka/pull/20002#discussion_r2166506244
##########
core/src/test/scala/unit/kafka/server/ClientQuotasRequestTest.scala:
##########
@@ -202,10 +203,12 @@ class ClientQuotasRequestTest(cluster: ClusterInstance) {
val entityFilter =
ClientQuotaFilterComponent.ofEntity(ClientQuotaEntity.IP, knownHost)
val defaultEntityFilter =
ClientQuotaFilterComponent.ofDefaultEntity(ClientQuotaEntity.IP)
val allIpEntityFilter =
ClientQuotaFilterComponent.ofEntityType(ClientQuotaEntity.IP)
-
+ val properties = new Properties()
+ properties.put(AdminClientConfig.BOOTSTRAP_SERVERS_CONFIG,
cluster.bootstrapServers())
+ val admin = AdminClient.create(properties)
def verifyIpQuotas(entityFilter: ClientQuotaFilterComponent,
expectedMatches: Map[ClientQuotaEntity, Double]): Unit = {
TestUtils.tryUntilNoAssertionError() {
- val result =
describeClientQuotas(ClientQuotaFilter.containsOnly(List(entityFilter).asJava))
+ val result =
admin.describeClientQuotas(ClientQuotaFilter.containsOnly(List(entityFilter).asJava)).entities().get()
Review Comment:
perhaps we could revert those changes, since this class should be migrated
to java code.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
