squah-confluent commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2174889060
########## group-coordinator/src/test/java/org/apache/kafka/coordinator/group/GroupMetadataManagerTest.java: ########## @@ -20382,19 +20382,15 @@ public void testConsumerGroupMemberJoinsWithUpdatedRegex() { .setMemberEpoch(10) .setHeartbeatIntervalMs(5000) .setAssignment(new ConsumerGroupHeartbeatResponseData.Assignment() - .setTopicPartitions(List.of( - new ConsumerGroupHeartbeatResponseData.TopicPartitions() - .setTopicId(fooTopicId) - .setPartitions(List.of(0, 1, 2, 3, 4, 5)) - )) + .setTopicPartitions(List.of()) ), - result.response() + result1.response() ); ConsumerGroupMember expectedMember1 = new ConsumerGroupMember.Builder(memberId1) .setState(MemberState.STABLE) .setMemberEpoch(10) - .setPreviousMemberEpoch(0) + .setPreviousMemberEpoch(10) Review Comment: The member epoch and previous member epoch before the heartbeat is 10. After the heartbeat, the previous member epoch should still be 10, not 0. This wasn't an issue previously because `newConsumerGroupMemberSubscriptionRecord` and `newConsumerGroupCurrentAssignmentRecord` don't put the previous member epoch into any records. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org