dajac commented on code in PR #20055: URL: https://github.com/apache/kafka/pull/20055#discussion_r2174940775
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java: ########## @@ -2305,6 +2305,9 @@ private CoordinatorResult<ConsumerGroupHeartbeatResponseData, CoordinatorRecord> group::currentPartitionEpoch, targetAssignmentEpoch, targetAssignment, + group.resolvedRegularExpressions(), + // Force consistency with the subscription when the subscription has changed. + bumpGroupEpoch || hasMemberRegularExpressionChanged(member, updatedMember), Review Comment: I agree that we should not trigger an assignment. My point is more about the structure of the code. We have all the subscription checks over there except this one. It would be better if we could define a boolean over there too and combine checks if possible. For instance, the method checking the regex could return a record with two booleans or we could refactor it differently. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org