lucasbru commented on code in PR #19967:
URL: https://github.com/apache/kafka/pull/19967#discussion_r2192293845
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigManager.java:
##########
@@ -36,8 +38,11 @@ public class GroupConfigManager implements AutoCloseable {
private final Map<String, GroupConfig> configMap;
+ private final Map<String, List<GroupConfigListener>> listenerMap;
+
public GroupConfigManager(Map<?, ?> defaultConfig) {
this.configMap = new ConcurrentHashMap<>();
+ this.listenerMap = new ConcurrentHashMap<>();
Review Comment:
We don't seem to ever remove anything from this map. This means we are
adding a memory leak here, right?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
