lucasbru commented on code in PR #19967: URL: https://github.com/apache/kafka/pull/19967#discussion_r2194565061
########## group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupConfigListener.java: ########## @@ -0,0 +1,27 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kafka.coordinator.group; + +import java.util.Properties; + +public interface GroupConfigListener { Review Comment: Ideally, we'd want to avoid new collections altogether. Couldn't we do soomething like this: - Add a new method `onGroupConfigChanged` to Group. Could be a separate interface, or just in the existing group interface. - Add a defauly implementation that does nothing - Implement it in `StreamsGroup` to set an internal flag to trigger a config-related rebalance - Add a method to `GroupMetadataManager` to call `onGroupConfigChanged` for the right group. - Hook up `GroupMetadataManager` and `GroupConfigManager` so that the latter calls the former when a group config changes. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
