zzbennett commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2205958400


##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/streams/topics/EndpointToPartitionsManager.java:
##########
@@ -38,7 +38,7 @@ private EndpointToPartitionsManager() {
     public static StreamsGroupHeartbeatResponseData.EndpointToPartitions 
endpointToPartitions(final StreamsGroupMember streamsGroupMember,
                                                                                
               final StreamsGroupHeartbeatResponseData.Endpoint 
responseEndpoint,
                                                                                
               final StreamsGroup streamsGroup,
-                                                                               
               final MetadataImage metadataImage) {
+                                                                               
               final CoordinatorMetadataImage metadataImage) {

Review Comment:
   I was considering that. But since the `CoordinatorMetadataImage` should be 
used in the same way as the `MetadataImage`, and there should not be a use case 
where both images are being used for different purposes, I felt that keeping 
the `metadataImage` name better conveys how the image should be used.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to