zzbennett commented on code in PR #20061:
URL: https://github.com/apache/kafka/pull/20061#discussion_r2191453404
##########
group-coordinator/src/main/java/org/apache/kafka/coordinator/group/GroupMetadataManager.java:
##########
@@ -4904,24 +4900,20 @@ public CoordinatorResult<Void, CoordinatorRecord>
uninitializeShareGroupState(
}
private Map<Uuid, String> attachTopicName(Set<Uuid> topicIds) {
- TopicsImage topicsImage = metadataImage.topics();
Map<Uuid, String> finalMap = new HashMap<>();
for (Uuid topicId : topicIds) {
- TopicImage topicImage = topicsImage.getTopic(topicId);
- String topicName = (topicImage != null) ? topicImage.name() :
"<UNKNOWN>";
+ String topicName =
metadataImage.topicName(topicId).orElse("<UNKNOWN>");
Review Comment:
as discussed offline, in order to avoid making functional changes in the PR,
I think we decided to keep it as `<UNKNOWN>` for now
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
