Pankraz76 commented on code in PR #20219:
URL: https://github.com/apache/kafka/pull/20219#discussion_r2222808362
##########
gradle/wrapper/gradle-wrapper.properties:
##########
@@ -1,7 +1,7 @@
distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
-distributionSha256Sum=845952a9d6afa783db70bb3b0effaae45ae5542ca2bb7929619e8af49cb634cf
-distributionUrl=https\://services.gradle.org/distributions/gradle-8.14.1-bin.zip
Review Comment:
does dependabot not check for this?
##########
build.gradle:
##########
@@ -29,18 +34,43 @@ buildscript {
}
plugins {
- id 'com.github.ben-manes.versions' version '0.48.0'
- id 'idea'
- id 'jacoco'
- id 'java-library'
- id 'org.owasp.dependencycheck' version '8.2.1'
- id 'org.nosphere.apache.rat' version "0.8.1"
+ id "com.diffplug.spotless" version "7.2.1"
+ id "com.github.ben-manes.versions" version "0.48.0"
+ id "com.github.spotbugs" version "6.0.25" apply false
+ id "com.gradleup.shadow" version "8.3.6" apply false
+ id "idea"
id "io.swagger.core.v3.swagger-gradle-plugin" version "${swaggerVersion}"
+ id "jacoco"
+ id "java-library"
+ id "org.nosphere.apache.rat" version "0.8.1"
+ id "org.openrewrite.rewrite" version "7.10.0"
+ id "org.owasp.dependencycheck" version "8.2.1"
+ id "org.scoverage" version "8.0.3" apply false
+}
+
+rewrite {
+ activeRecipe("org.openrewrite.gradle.GradleBestPractices")
+ activeRecipe("org.openrewrite.java.RemoveUnusedImports")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedLocalVariables")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateFields")
+ activeRecipe("org.openrewrite.staticanalysis.RemoveUnusedPrivateMethods")
+ failOnDryRunResults = true
+}
+
+spotless {
+ java {
+ targetExclude('**/generated/**/*.java','**/generated-test/**/*.java')
+ importOrder('kafka', 'org.apache.kafka', 'com', 'net', 'org', 'java',
'javax', '', '\\#')
+ //licenseHeaderFile("$rootDir/checkstyle/java.header", 'package') todo
apply me
+ }
+ scala {
+
scalafmt("$versions.scalafmt").configFile("$rootDir/checkstyle/.scalafmt.conf").scalaMajorVersion(versions.baseScala)
+ //licenseHeaderFile("$rootDir/checkstyle/java.header", 'package') todo
apply me
+ }
+}
- id "com.github.spotbugs" version '6.0.25' apply false
- id 'org.scoverage' version '8.0.3' apply false
- id 'com.gradleup.shadow' version '8.3.6' apply false
- id 'com.diffplug.spotless' version "6.25.0"
Review Comment:
does dependabot not check for this?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
