Pankraz76 commented on code in PR #20219: URL: https://github.com/apache/kafka/pull/20219#discussion_r2232834298
########## build.gradle: ########## Review Comment: Yes, thanks for pointing out. Indeed, Rewrite has the ability to take over, making Spot and Check obsolete, considering the recipe: - [AutoFormat Recipe - OpenRewrite Docs](https://docs.openrewrite.org/recipes/java/format/autoformat) As a potential migration is too much for now, this PR is considered kind of PoC. The import case is a good example - Rewrite has also bugs of course, but in this case seems to be stronger due to the type awareness. Assuming Spot (which uses Google's formatter) is just a simple file parser like Checkstyle, it has a lot of blind spots in the unused imports theme again. > 2\. Disabling import handling in one of the tools yes shifted from spot to rewrite demonstrating the leftovers. > * Using only Spotless for formatting/imports and Rewrite for code cleanup yes thats the goal to later on check if spot is still necessary. But first start small then continue. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
