Pankraz76 commented on code in PR #20214:
URL: https://github.com/apache/kafka/pull/20214#discussion_r2223355066
##########
trogdor/src/main/java/org/apache/kafka/trogdor/rest/ErrorResponse.java:
##########
@@ -22,46 +22,29 @@
import com.fasterxml.jackson.annotation.JsonCreator;
import com.fasterxml.jackson.annotation.JsonProperty;
-import java.util.Objects;
-
/**
* An error response.
*/
-public class ErrorResponse {
- private final int code;
- private final String message;
-
+public record ErrorResponse(int code, String message) {
@JsonCreator
public ErrorResponse(@JsonProperty("code") int code,
@JsonProperty("message") String message) {
this.code = code;
this.message = message;
}
+ @Override
Review Comment:
nicely done, thanks. Until taken care by plugin it can happen anytime
leaving this task kind of open. Offering to apply thins kind of conventions via
rewrite.
-
https://docs.openrewrite.org/recipes/staticanalysis/missingoverrideannotation
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
