sjhajharia commented on code in PR #20214:
URL: https://github.com/apache/kafka/pull/20214#discussion_r2256733952


##########
trogdor/src/main/java/org/apache/kafka/trogdor/workload/PartitionsSpec.java:
##########
@@ -84,7 +83,9 @@ public List<Integer> partitionNumbers() {
             }
             return partitionNumbers;
         } else {
-            return new ArrayList<>(partitionAssignments.keySet());
+            ArrayList<Integer> partitionNumbers = new 
ArrayList<>(partitionAssignments.keySet());
+            partitionNumbers.sort(Integer::compareTo);

Review Comment:
   This was done because `TopicsSpecTest.testPartitionNumbers` became flaky 
after the changes. Upon further consideration, I re-did the test rather than 
add a complexity here. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to