m1a2st commented on code in PR #20218:
URL: https://github.com/apache/kafka/pull/20218#discussion_r2225836893
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -1031,6 +1031,7 @@ private void copyLogSegment(UnifiedLog log, LogSegment
segment, RemoteLogSegment
customMetadata =
remoteStorageManagerPlugin.get().copyLogSegmentData(copySegmentStartedRlsm,
segmentData);
} catch (RemoteStorageException e) {
logger.info("Copy failed, cleaning segment {}",
copySegmentStartedRlsm.remoteLogSegmentId());
+ recordLagStats(log);
Review Comment:
Yes, we should also handle the RLMM-related methods. The following methods
should be covered:
- `addRemoteLogSegmentMetadata`
- `updateRemoteLogSegmentMetadata`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
