kamalcph commented on code in PR #20218:
URL: https://github.com/apache/kafka/pull/20218#discussion_r2226098048
##########
storage/src/main/java/org/apache/kafka/server/log/remote/storage/RemoteLogManager.java:
##########
@@ -973,6 +973,9 @@ public void copyLogSegmentsToRemote(UnifiedLog log) throws
InterruptedException
segmentIdsBeingCopied.add(segmentId);
try {
copyLogSegment(log,
candidateLogSegment.logSegment, segmentId,
candidateLogSegment.nextSegmentOffset);
+ } catch (RemoteStorageException e) {
Review Comment:
can we catch all exception in the `catch` block and then throw it?
RemoteStorageException -> Exception
since `copyLogSegment` throws InterruptedException, ExecutionException,
RemoteStorageException, IOException, and
CustomMetadataSizeLimitExceededException:
```
catch (Exception e) {
recordLagStats(log);
throw e;
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
