ahuang98 commented on code in PR #19854:
URL: https://github.com/apache/kafka/pull/19854#discussion_r2226443533
##########
raft/src/test/java/org/apache/kafka/raft/KafkaRaftClientTest.java:
##########
@@ -2033,6 +2033,40 @@ public void
testUnattachedAsVoterCanBecomeFollowerAfterFindingLeader(boolean wit
assertTrue(context.client.quorum().isFollower());
}
+ @ParameterizedTest
+ @ValueSource(booleans = { true, false })
+ public void
testUnattachedWithLeaderCanBecomeFollowerAfterFindingLeader(boolean
withKip853Rpc) throws Exception {
Review Comment:
this name was incorrect and should have been something like
`testProspectiveWithLeaderCanBecomeFollower` - but in that case it already
duplicates a test in KafkaRaftClientPreVoteTest so I'm deleting this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
