DL1231 commented on code in PR #20248:
URL: https://github.com/apache/kafka/pull/20248#discussion_r2244552547
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -315,11 +305,9 @@ private static void handleUpgradeOrDowngrade(String op,
Namespace namespace, Adm
if (metadata != null) {
System.out.println(" `metadata` flag is deprecated and may be
removed in a future release.");
try {
- metadataVersion =
MetadataVersion.fromVersionString(metadata);
+ metadataVersion =
MetadataVersion.fromVersionString(metadata, false);
Review Comment:
This refers to the original
[implementation](https://github.com/apache/kafka/blob/trunk/tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java#L298-L300).
When originally throwing an exception using
`MetadataVersion.latestProduction()`, the parameter passed to
`fromVersionString()` was `false`. When originally throwing an exception using
`MetadataVersion.latestTesting()`, the parameter passed to
`fromVersionString()` was `true`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
