chia7712 commented on code in PR #20248:
URL: https://github.com/apache/kafka/pull/20248#discussion_r2245241241
##########
tools/src/main/java/org/apache/kafka/tools/FeatureCommand.java:
##########
@@ -315,11 +305,9 @@ private static void handleUpgradeOrDowngrade(String op,
Namespace namespace, Adm
if (metadata != null) {
System.out.println(" `metadata` flag is deprecated and may be
removed in a future release.");
try {
- metadataVersion =
MetadataVersion.fromVersionString(metadata);
+ metadataVersion =
MetadataVersion.fromVersionString(metadata, false);
Review Comment:
Yes, it remains consistent with the original implementation. However, it
also introduces a new restriction
```java
} else if (!unstableFeatureVersionsEnabled &&
!metadataVersion.isProduction()) {
throw new IllegalArgumentException(errorMsg);
```
For example, users may download the trunk source code to test an upgrade
with an older version of Kafka, and this new restriction could prevent them
from upgrading to a non-production MV. Shouldn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
