sjhajharia commented on code in PR #20180:
URL: https://github.com/apache/kafka/pull/20180#discussion_r2275435455
##########
server/src/main/java/org/apache/kafka/server/purgatory/DelayedDeleteRecords.java:
##########
@@ -57,7 +56,7 @@ public DelayedDeleteRecords(long delayMs,
Consumer<Map<TopicPartition,
DeleteRecordsPartitionResult>> responseCallback) {
super(delayMs);
this.onAcksPending = onAcksPending;
- this.deleteRecordsStatus =
Collections.unmodifiableMap(deleteRecordsStatus);
+ this.deleteRecordsStatus = Map.copyOf(deleteRecordsStatus);
Review Comment:
I agree with the later. Lets keep it as Map.copyOf and revisit the same once
the Java conversion is complete.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
