chia7712 commented on code in PR #20334:
URL: https://github.com/apache/kafka/pull/20334#discussion_r2311756677
##########
clients/src/test/java/org/apache/kafka/clients/producer/KafkaProducerTest.java:
##########
@@ -637,30 +637,30 @@ props, new StringSerializer(), new StringSerializer())) {
MockProducerInterceptor.resetCounters();
}
}
+
@Test
- public void
testInterceptorConstructorConfigurationWithExceptionShouldCloseRemainingInstances()
{
- final int targetInterceptor = 3;
+ public void
testInterceptorConstructorExceptionShouldCloseCreatedInstance() {
+ final int targetInterceptor = 1;
try {
Properties props = new Properties();
props.setProperty(ProducerConfig.BOOTSTRAP_SERVERS_CONFIG,
"localhost:9999");
- props.setProperty(ProducerConfig.INTERCEPTOR_CLASSES_CONFIG,
org.apache.kafka.test.MockProducerInterceptor.class.getName() + ", "
- +
org.apache.kafka.test.MockProducerInterceptor.class.getName() + ", "
- +
org.apache.kafka.test.MockProducerInterceptor.class.getName());
+ props.setProperty(ProducerConfig.INTERCEPTOR_CLASSES_CONFIG,
org.apache.kafka.test.MockProducerInterceptor.class.getName());
props.setProperty(MockProducerInterceptor.APPEND_STRING_PROP,
"something");
MockProducerInterceptor.setThrowOnConfigExceptionThreshold(targetInterceptor);
assertThrows(KafkaException.class, () ->
- new KafkaProducer<>(props, new StringSerializer(), new
StringSerializer())
+ new KafkaProducer<>(props, new StringSerializer(), new
StringSerializer())
Review Comment:
Please remove this change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: jira-unsubscr...@kafka.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
